jordansissel
commented
8 years ago The frame type is included. https://github.com/elastic/ruby-lumberjack/blob/master/lib/lumberjack/client.rb#L146
The unmentioned reporting case for this is the user was reporting this error message (excuse any typos, I am transcribing from a screenshot):
Client write error, trying to connect {:e =#<RuntimeError: Whoa we shouldn't get this frame: >, ...In this case, it looks like the type trying to be logged was actually an empty string or a nil (both to_s to empty strings). This could be caused by the socket read returning nil or empty string for the frame type in the read_version_and_type method - https://github.com/elastic/ruby-lumberjack/blob/master/lib/lumberjack/client.rb#L158
My belief in this is based on the exception text:
#<RuntimeError: Whoa we shouldn't get this frame: >And the exception message code:
Whoa we shouldn't get this frame: #{type}As you can see in the RuntimeError, the text ends frame: followed by a space. (The > is just Ruby's way of showing you an object inspection, #<SomeClass ....>, and is not part of the text).
aadicodes
jsdumont
This error can happen when an incorrect frame is send back from the server and its confusing and hard to debug. I suggest that we at least include the
frame_typethat we received to get a better ideas of what actually happened.Just a note the only frame that the server can send is
Aso I dont know what actually is happenning here. Probably something bad was raised on the server side?