search

logstash-plugins / logstash-output-riemann

Apache License 2.0
5 stars 13 forks source link

Fix crash in map_fields and fix riemann_event for "%{field}" strings #1

Closed venturaville closed 9 years ago

jordansissel commented 10 years ago

Prior conversations here: https://github.com/elasticsearch/logstash-contrib/pull/136

venturaville commented 10 years ago

I can add an explanation of what broke versus not, but I am not sure where plugin doc updates go...

jordansissel commented 10 years ago

ahh I should have been more clear, sorry!

Doc updates - docs live inside the plugin itself. The comments above the 'config' lines become the docs for that config setting. The comments above the class definition for the plugin become the description/etc of the plugin in its documentation.

venturaville commented 10 years ago

per you request, this problem is to address a conflict between map_fields and riemann_event. riemann_event wants to be able to map fields using "%{fieldName}" similar to what other modules do. map_fields does not use the sprintf from the event which allows for that and instead just blindly writes things out which results in the raw "%{fieldName}" showing up in the results instead of the substituted field.

hmrm commented 9 years ago

@jordansissel @venturaville Anything in the way of getting this merged?

corradio commented 9 years ago

Heavily interested in this! Let me know if I can help!

adnan-panalytics commented 9 years ago

@jordansissel @ph Is there any reason why this fix has not been merged? Need to update our logstash config, and this merge is vital to it.

jamtur01 commented 9 years ago

Any chance of movement on this? It's blocking a deployment for us too. Happy to patch locally but would prefer upstream.

jsvd commented 9 years ago

@venturaville since you signed the cla with a different email than the one in this pr would you mind force pushing it again with the cla email so we can merge this?

jamtur01 commented 9 years ago

@venturaville Any chance of a new push? If not - would you be cool if someone took over the patch and submitted it? Thanks!

venturaville commented 9 years ago

I signed the CLA with my venturaville account. Should be good now.

jamtur01 commented 9 years ago

@venturaville Awesome - thanks so much!

@jordansissel All yours! :)

venturaville commented 9 years ago

Any suggestions on how to do a force push? It looks as though github was picking up my non-personal key and ignoring my personal one.

jamtur01 commented 9 years ago

git push --force not working?

jamtur01 commented 9 years ago

@venturaville Can I help with a push in some way?