search

logstash-plugins / logstash-output-s3

Apache License 2.0
58 stars 151 forks source link

Crash recovery now respects retry_count and retry_delay #254

Open chrisboulton opened 1 year ago

chrisboulton commented 1 year ago

We noticed that during crash recovery the configurable retry settings (count and delay) were not respected. I wasn't sure if there was a reason for this, but if not this PR addresses that behaviour.

Previously while performing crash recovery:

[2023-01-31T17:32:53,179][WARN ][logstash.outputs.s3      ] Uploading failed, retrying (#78 of Infinity) {:exception=>Aws::S3::Errors::AccessDenied,...

Now:

[2023-01-31T17:52:00,265][WARN ][logstash.outputs.s3      ] Uploading failed, retrying (#3 of 50) {:exception=>Aws::S3::Errors::AccessDenied, :message=>"Access Denied",...