logstash-plugins / logstash-output-sqs

Apache License 2.0
4 stars 22 forks source link

Adding support for FIFO Queues #35

Open hobsons-feliperoque opened 4 years ago

hobsons-feliperoque commented 4 years ago

This plugin as it currently stands does not support FIFO Queues. It is missing the following required fields:

This PR aims to make it compatible, by adding those two fields to the send-message requests whenever the Queue name contains .fifo, which is the required suffix for FIFO Queues.

The Group Id is what ensures the FIFO behaviour of the Queue, but only if it's the same for every message, it's setting a default value for it, which will ensure the FIFO behaviour, but it can be overwritten if needed.

The Deduplication Id must be unique to every message if you want it to be sent, so unless otherwise specified, it's generating a uuid for it for every send request.

elasticcla commented 4 years ago

Hi @hobsons-feliperoque, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

crael commented 4 years ago

Is this PR dead if @hobsons-feliperoque doesn't update his profile? The changes look like a nice addition to the official plugin.

mahadevans87 commented 4 years ago

Any update on this. This feature is a nice to have!