search

logstash-plugins / logstash-output-tcp

Apache License 2.0
9 stars 31 forks source link

reconnect_interval not used for reconnect, Stud::try log not in Logstash log file #12

Closed breml closed 2 years ago

breml commented 8 years ago

For reconnects Stud::try is used (https://github.com/logstash-plugins/logstash-output-tcp/blob/master/lib/logstash/outputs/tcp.rb#L123), which has two side effects:

  1. Stud::try does not respect the reconnect_interval configured for the plugin but its own intervals, defined in https://github.com/jordansissel/ruby-stud/blob/master/lib/stud/try.rb#L26
  2. Stud::try does not log to the Logstash log file but to stdout, which makes problem finding very difficult, if logstash is executed as a service.
PaddyFOpenet commented 4 years ago

Just wondering if there was any consideration given to this; Stud:try preventing reconnect_intervalfrom having an affect seems like a bug to me?