search

logstash-plugins / logstash-patterns-core

Apache License 2.0
2.17k stars 979 forks source link

adds lowercase to TZ pattern #230

Closed Rock-HOG closed 4 years ago

Rock-HOG commented 6 years ago

some log entries may show lowercase timezone.

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

Rock-HOG commented 6 years ago

I have signed the CLA.

Thanks

jsvd commented 6 years ago

would you mind adding tests for this change? there are many examples of tests in the spec/ folder

kares commented 4 years ago

Thanks for the PR, seems like this has been stale for a while. Since the PR was opened a discussion went on at https://github.com/logstash-plugins/logstash-patterns-core/issues/172.

Lower-case names seem quite uncommon and instead the issue focuses on matching more time-zones. I know Ruby would match such strings but that is more of an implementation detail I believe than an actual intent. Going to close this one in favour of https://github.com/logstash-plugins/logstash-patterns-core/pull/235, if anyone is seeing lower-case TZ identifiers produced please let us know more details (sample logs) on what kind of apps/services produce them.