search

logstash-plugins / logstash-patterns-core

Apache License 2.0
2.17k stars 979 forks source link

Remove duplicate patterns JAVACLASS and JAVAFILE #237

Closed jsvd closed 5 years ago

jsvd commented 5 years ago

/cc @jakelandis as this duplication also exists in https://github.com/elastic/elasticsearch/blob/6.5/libs/grok/src/main/resources/patterns/java

jsvd commented 5 years ago

maybe some comment in the commit/changelog as to the reasons why those definitions were removed

@robbavey that was my goal with the tests, both test an example of the pattern that only works for the remaining one.

robbavey commented 5 years ago

@jsvd Ah cool, ok LGTM then

jakelandis commented 5 years ago

@jsvd - thanks for the heads up, issue logged for the ingest node: https://github.com/elastic/elasticsearch/issues/35699