Deprecated dependencies

logtail / logback-logtail

Better Stack Java Logback appender

https://betterstack.com/logs

MIT License

17 stars 4 forks source link

Deprecated dependencies #7

Closed ggomarighetti closed 2 years ago

ggomarighetti commented 2 years ago

Resume

Deprecated dependencies replaced
Updated the remaining dependencies
Updated thread sleep time in a test
Updated the readme.md file example

Evidence

Reference

Not created/Not required

adikus commented 2 years ago

Thanks @ggomarighetti! I'll try to review this ASAP!

ggomarighetti commented 2 years ago

The changes made to the test may have been due to my latency with the servers (Argentina, South America).

adikus commented 2 years ago

@ggomarighetti Looks like the build is failing, would you be able to have a look at that?

ggomarighetti commented 2 years ago

@ggomarighetti Looks like the build is failing, would you be able to have a look at that?

The tests require an ingest key in the configurations, as I saw in a previous PR, you assigned them in your test environment, I didn't want to upload mine, that's why it fails.

adikus commented 2 years ago

@ggomarighetti We have the ingest key configured in GitHub actions - so that should be fine. Looks like this is a Java compile error, possibly due to a different Java version that we are using vs. what the new packages were compiled with.

ggomarighetti commented 2 years ago

You are absolutely right, I am working with the latest LTS version, number 17.

ggomarighetti commented 2 years ago

I downgraded the version number of the dependency by 0.1 difference, since the new versions are compiled with JDK 9.

ggomarighetti commented 2 years ago

Evidence

adikus commented 2 years ago

@ggomarighetti Thanks! Looks great! This time it failed trying to send logs to Logtail, so our test key it probably not correct anymore after all. I'll look into that tomorrow!

ggomarighetti commented 2 years ago

@ggomarighetti Thanks! Looks great! This time it failed trying to send logs to Logtail, so our test key it probably not correct anymore after all. I'll look into that tomorrow!

Message

In the pull request where these tests were introduced, the comment was made that when tested locally, it passed without problems. Possibly it is not an expired key, but a bug in the github actions of the project.

Reference

https://github.com/logtail/logback-logtail/pull/5#issuecomment-1065099908

ggomarighetti commented 2 years ago

@adikus Reversed the requested line at README.md file.

adikus commented 2 years ago

Thank you! I'll get this released as soon as possible.