search

logto-io / js

🤓 Logto JS SDKs.
https://docs.logto.io/quick-starts/
MIT License
61 stars 40 forks source link

bug: support LTS Node.js #613

Closed David-van-der-Sluijs closed 8 months ago

David-van-der-Sluijs commented 8 months ago

When using the latest LTS Node.js version (v20.11.0) the npm install command fails:

npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: @silverhand/essentials@2.8.6
npm ERR! notsup Not compatible with your version of node/npm: @silverhand/essentials@2.8.6
npm ERR! notsup Required: {"node":"^16.13.0 || ^18.12.0 || ^19.2.0","pnpm":"^8.0.0"}
npm ERR! notsup Actual:   {"npm":"10.3.0","node":"v20.11.0"}
charIeszhao commented 8 months ago

Thanks for the feedback. We'll take a look and keep you updated

charIeszhao commented 8 months ago

This should have been fixed in the latest version. It's been releasing now to the NPM. Please wait for a minutes and check it out. Let us know if you have other issues. Cheers!

David-van-der-Sluijs commented 8 months ago

Thank you very much for the speedy fix! I can indeed confirm it installs now without a problem.

Jogai commented 7 months ago

Why restrict it to lts? Just a minimum should be enough I'd think.