search

logtrace / material-icons-react

Google material icons implementation for React
MIT License
24 stars 16 forks source link

Add prop-types #10

Closed ajayns closed 6 years ago

ajayns commented 6 years ago

References #7

Still in development, I'll add changes as we progress in our discussion. This is just to check the code changes I've made and review.

@sithumn

ajayns commented 6 years ago

I was thinking we could come up with a an alternate way of assigning default props maybe using prop-types. Would this be a good idea? Plus, it'd help me understanding better if you could tell me why prop-type defaults are preferred for use?

@sithumn @rafaelklaessen

rafaelklaessen commented 6 years ago

Yeah you could use defaultProps. That would be preferred because it separates prop logic from component logic, thus resulting in cleaner code.

ajayns commented 6 years ago

@rafaelklaessen Thanks, that makes sense. I'll see what I can do!

sithumn commented 6 years ago

:tada: This PR is included in version 1.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: