logtrace / material-icons-react

Google material icons implementation for React
MIT License
24 stars 16 forks source link

Text while loading #13

Closed amit0001 closed 6 years ago

amit0001 commented 6 years ago

While the icons load there is text, which looks ugly. Best to just have nothing until the icon loads.

sithumn commented 6 years ago

Hi,

I cannot reproduce this issue. Can you explain what you did and other specifics like browser, react version etc...

blakewilson commented 6 years ago

HI,

I am also experiencing this issue. I found that it renders the Material Icon's text inside of the <i></i> while loading. This causes the element to expand in width temporarily and then revert back once the icon gets loaded in.

You can reproduce this issue by doing the following:

material-icons-react

Chrome version: 68.0.3440.84 React version 16.4.2 Material Icons React Version: 1.0.2

sithumn commented 6 years ago

@blakewilson Thanks for the details will look in to this during this weekend.

imbroisi commented 6 years ago

Hi! I have the same problem. Any news about the solution? Thanks.

sithumn commented 6 years ago

I'm sorry guys. I've been working on this and had a very busy schedule. I'll finalize a fix and push ASAP.

sithumn commented 6 years ago

Hi,

I've fixed this. Please have a look at the latest version. I'm closing this issue.

Regards, Sithum

amit0001 commented 6 years ago

👍Thanks. I'm on a different project, so can't check it but hope others will benefit.