search

logtrace / material-icons-react

Google material icons implementation for React
MIT License
24 stars 16 forks source link

Refactor MaterialIcon into a Functional Component #5

Closed ajayns closed 6 years ago

ajayns commented 6 years ago

References #4

As suggested in various docs, for stateless components, arrow functions are recommended as it makes the code less verbose and also is better optimized by React. Ref links and discussion in the issue.

It passes all tests and I've also ran it through a simple React app, works same as before, even with the code change.

@sithumn Please review

ajayns commented 6 years ago

@sithumn Review this PR as well.

And also, I'd like to discuss something with you, what would be the best way of reaching you? Email id/chat?

sithumn commented 6 years ago

:tada: This PR is included in version 1.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: