logue / vite-vue2-vuetify-ts-starter

@vitejs template for @vuejs 2+@vuetifyjs+TypeScript
MIT License
84 stars 31 forks source link

No javascript text is not wrapped in <noscript> #6

Closed amit-feldman closed 1 year ago

amit-feldman commented 1 year ago

@logue you should consider wrapping the text We're sorry but this site doesn't work properly without JavaScript enabled. Please enable it to continue. in the index.html file in a <noscript></noscript> tag instead of the <div id="app"></div>

logue commented 1 year ago

This is the default text generated by Vue-CLI.

I heard that the noscript tag is deprecated... https://www.w3.org/html/wg/tracker/issues/117

amit-feldman commented 1 year ago

@logue yeah there are a bunch of options instead of using the noscript tag, however the text is displayed everytime before the app loads and looks ugly 😄. Just a suggestion though

logue commented 1 year ago

Well, it feels like putting a witty message or image on your own. Anyway, I think that the contents of the title tag should be rewritten.🙂