logue / vue-codemirror6

⌨️ @codemirror 6 component for @vuejs. Vue2 & Vue3 both supported.
https://logue.dev/vue-codemirror6/
MIT License
138 stars 18 forks source link

Node 16 requirement #1

Open Dutch77 opened 2 years ago

Dutch77 commented 2 years ago

Is node 16 really neccessary?

logue commented 2 years ago

I set it to 16 simply because it's a long-term stable (LTS).

ricardo17coelho commented 1 year ago

and node 18.15 is also necessary for LTS ? I add this project and dependency and start work with it 2-3 weeks ago... i need to update my node env to v. 18.14.. (was already a challenge) and now the project was updated again to v. 18.15 😔

Dutch77 commented 1 year ago

@logue

  "peerDependencies": {
    "vue": "^2.7.14 || ^3.2.47"
  },

also this forces user update vue to up to this version. Minor/feature lock is understandable, but you do not want force patch version. Just lock it at version that your project need for running please.

Sometimes it can be really diffucult to meet requirements because of this.

Same thing applies to locked version of node 18. At the time I was writing this issue, your package run perfectly fine with node 14. No every project can be upgraded to such version. Just lock it on minimal version possible please.

logue commented 1 year ago

I understand about the version of node. From now on, I will put the version defined in Vue used for development. (Currently >=16.11.0) https://github.com/vuejs/core/blob/main/package.json

Regarding peerDependencies, vue2.6.x was the minimum version, but expose was not implemented, and there was a problem that it did not work, so we could not carelessly lower the minimum version.

However, since I think that it will work with Vue 3.2 or later, a minor version may not be necessary there.

logue commented 1 year ago

After much thought, I came to the conclusion that the dependency version should be determined in the base Vue and not defined in the component.