search

logv / snorkel

UI for interactive data analysis | https://snorkel.logv.org
https://fb.com/groups/snorkelsnorkelsnorkel
161 stars 21 forks source link

error responses are not rendered for the user #44

Closed tmc closed 5 years ago

tmc commented 5 years ago

Example run_query response: {"__request__": {"activations": [], "css": []}, "cmp_644ad916a4": {"error": "('Unknown time string: ', u'-1 week')"}, "cmp_2aba949fda": {"activations": [], "html": [], "calls": []}, "__versions__": {}}

these errors aren't rendered for the user.

okayzed commented 5 years ago

thanks! I'll add something for that this week

okayzed commented 5 years ago

4094af431c403c231992fceb50f7a35033aaee1f adds a simple modal dialog for errors. i tested it by supplying invalid times to the custom time inputs