search

logv / sybil

columnar storage + NoSQL OLAP engine | https://logv.org
https://logv.org
Other
305 stars 25 forks source link

Update scripts to be Python3 compatible. #103

Closed gouthamve closed 5 years ago

gouthamve commented 5 years ago

Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com

codecov[bot] commented 5 years ago

Codecov Report

Merging #103 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   49.84%   49.84%           
=======================================
  Files          37       37           
  Lines        3766     3766           
=======================================
  Hits         1877     1877           
  Misses       1686     1686           
  Partials      203      203
Flag Coverage Δ
#unittests 49.84% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8000982...9e4ff2d. Read the comment docs.

okayzed commented 5 years ago

thanks! for the print statements, those files should have "from future import print_function" at the top so they are compatible with python2 as well. otherwise, in python2, an extra pair of parens will be printed

okayzed commented 5 years ago

also, please notice that i've moved to using plait.py for generating data. you can use "plait.py scripts/plait/host_generator.yaml" to see how host_generator.py compares to host_generator.yaml