search

logv / sybil

columnar storage + NoSQL OLAP engine | https://logv.org
https://logv.org
Other
305 stars 24 forks source link

increase the amount of idiomatic go #36

Closed tmc closed 6 years ago

tmc commented 6 years ago

Refs #35

okayzed commented 6 years ago

cool! i'll finish reviewing and accept in the AM - looks like it passed all tests and some query commands i ran.

what was your regex/script for the changes? my guess is you used codemod/fastmod, but i'm curious how you ignored the under_case inside strings.

tmc commented 6 years ago

This was a set of vim macros. I could share them but they’re kind of gibberish. On Fri, May 11, 2018 at 9:01 PM okay notifications@github.com wrote:

cool! i'll finish reviewing and accept in the AM - looks like it passed all tests and some query commands i ran.

what was your regex/script for the changes? my guess is you used codemod/fastmod, but i'm curious how you ignored the under_case inside strings.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/logv/sybil/pull/36#issuecomment-388528007, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPicAz3bdteCOZwUGkKM3bThknuPOfks5txl6HgaJpZM4T8QPc .

tmc commented 6 years ago

Basically for a class of linter error I would write a macro that would address that and run it over the set of lint errors in that class.

By the way I’m totally happy/fine/supportive of you rewriting this change to set authorship back to the previous line’s author. On Fri, May 11, 2018 at 9:13 PM Travis Cline travis.cline@gmail.com wrote:

This was a set of vim macros. I could share them but they’re kind of gibberish. On Fri, May 11, 2018 at 9:01 PM okay notifications@github.com wrote:

cool! i'll finish reviewing and accept in the AM - looks like it passed all tests and some query commands i ran.

what was your regex/script for the changes? my guess is you used codemod/fastmod, but i'm curious how you ignored the under_case inside strings.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/logv/sybil/pull/36#issuecomment-388528007, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPicAz3bdteCOZwUGkKM3bThknuPOfks5txl6HgaJpZM4T8QPc .

okayzed commented 6 years ago

:lgtm:

seems like it will be a bit of work for me to take over the authorship of the lines, so i'll just leave as is. took long enough to read through the changes, anyways.

for testing: