logv / sybil

columnar storage + NoSQL OLAP engine | https://logv.org
https://logv.org
Other
305 stars 24 forks source link

Reduce reliance on globals #61

Closed tmc closed 6 years ago

tmc commented 6 years ago

Reduce the amount of global shared state (lowering FLAGS use in src/sybil).

codecov-io commented 6 years ago

Codecov Report

Merging #61 into master will increase coverage by 0.2%. The diff coverage is 18.51%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #61     +/-   ##
=========================================
+ Coverage   51.96%   52.16%   +0.2%     
=========================================
  Files          36       36             
  Lines        3720     3715      -5     
=========================================
+ Hits         1933     1938      +5     
+ Misses       1587     1580      -7     
+ Partials      200      197      -3
Impacted Files Coverage Δ
src/sybil/query_spec.go 57% <ø> (ø) :arrow_up:
src/sybil/table_ingest.go 55.29% <ø> (+0.64%) :arrow_up:
src/sybil/table_load_spec.go 28.2% <ø> (ø) :arrow_up:
src/sybil/config.go 78.12% <ø> (-0.34%) :arrow_down:
src/sybil/table_block_io.go 56.61% <ø> (-0.23%) :arrow_down:
src/sybil/node_aggregator.go 0% <0%> (ø) :arrow_up:
src/sybil/printer.go 0% <0%> (ø) :arrow_up:
src/sybil/aggregate.go 62.04% <0%> (ø) :arrow_up:
src/sybil/table_query.go 59.72% <44.44%> (+1.28%) :arrow_up:
src/sybil/query_cache.go 68.46% <60%> (+3.07%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60a53f9...71f0fa6. Read the comment docs.