search

logv / sybil

columnar storage + NoSQL OLAP engine | https://logv.org
https://logv.org
Other
305 stars 26 forks source link

Flags cleanup #75

Closed tmc closed 6 years ago

tmc commented 6 years ago

This eliminates unused flags and eliminates pointers which make the code a little more brittle and harder to fuzz test.

codecov-io commented 6 years ago

Codecov Report

Merging #75 into master will decrease coverage by 0.3%. The diff coverage is 43.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   52.44%   52.13%   -0.31%     
==========================================
  Files          37       37              
  Lines        3703     3675      -28     
==========================================
- Hits         1942     1916      -26     
+ Misses       1570     1569       -1     
+ Partials      191      190       -1
Impacted Files Coverage Δ
src/sybil/filter.go 49.26% <0%> (ø) :arrow_up:
src/sybil/printer.go 0% <0%> (ø) :arrow_up:
src/sybil/table_recover_info.go 0% <0%> (ø) :arrow_up:
src/sybil/table_block_io.go 56.61% <0%> (ø) :arrow_up:
src/sybil/table_trim.go 0% <0%> (ø) :arrow_up:
src/sybil/record_slab.go 50% <0%> (ø) :arrow_up:
src/sybil/table_block_sort.go 0% <0%> (ø) :arrow_up:
src/sybil/debug.go 11.11% <0%> (ø) :arrow_up:
src/sybil/table_column_info.go 91.3% <100%> (ø) :arrow_up:
src/sybil/row_store.go 81.6% <100%> (ø) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ca3a12...ab95ca9. Read the comment docs.