logv / sybil

columnar storage + NoSQL OLAP engine | https://logv.org
https://logv.org
Other
305 stars 26 forks source link

fix remote query path involving histograms #95

Closed okayzed closed 5 years ago

okayzed commented 5 years ago

commit 9a5f93c6f1dbc92c50a23d2e35881b77dd7db87a adds some strange behavior to remote queries involving histograms as noticed via git bisect

goroutine 1 [running]:
github.com/logv/sybil/src/sybil.(*BasicHist).Combine(0xc42009e7e0, 0x5f5ec0, 0xc42000d0a8)
        /home/okay/tonka/go/src/github.com/logv/sybil/src/sybil/hist_basic.go:267 +0x131
github.com/logv/sybil/src/sybil.(*Result).Combine(0xc4200e2980, 0xc4200e2740)
        /home/okay/tonka/go/src/github.com/logv/sybil/src/sybil/query_spec.go:166 +0x60d
github.com/logv/sybil/src/sybil.CombineResults(0xc4200c9bb0, 0xc4200c9898, 0xc420018b27)
        /home/okay/tonka/go/src/github.com/logv/sybil/src/sybil/aggregate.go:443 +0x313
github.com/logv/sybil/src/sybil.(*VTable).AggregateSpecs(0xc4200c9dd0, 0xc4200c9da8, 0xc42000e0b0, 0x1, 0x1)
        /home/okay/tonka/go/src/github.com/logv/sybil/src/sybil/node_aggregator.go:165 +0x3ed
github.com/logv/sybil/src/sybil.(*VTable).StitchResults(0xc4200c9dd0, 0xc4200c9da8, 0xc42000e0b0, 0x1, 0x1)
        /home/okay/tonka/go/src/github.com/logv/sybil/src/sybil/node_aggregator.go:189 +0xbd
github.com/logv/sybil/src/cmd.RunAggregateCmdLine()
        /home/okay/tonka/go/src/github.com/logv/sybil/src/cmd/cmd_aggregate.go:35 +0x237
main.main()
        /home/okay/tonka/src/sybil/main.go:98 +0xd1