Modification: Included --forever flag for script to run util any disruption is introduced

logzio / elasticsearch-stress-test

Stress test tool for Elasticsearch

Apache License 2.0

271 stars 110 forks source link

Modification: Included --forever flag for script to run util any disruption is introduced #22

Closed vibhor995 closed 2 years ago

vibhor995 commented 5 years ago

1) Added one flag which will continue the run of stress load until any chaos is introduced.

---forever == flag

Signed-off-by: vibhor995 vibhor.kumar@mayadata.io

@roiravhon can you please review this PR.

roiravhon commented 5 years ago

Hey @vibhor995 thanks for that!

But this change has some issues. First, the "seconds" argument is still mandatory - and should not be now. You should add a validation that either the seconds xor the forever flag is set, and move the logic of the "forever" to has_timeout function rather than a while true

Thanks, Roi