search

logzio / guice-jersey

Guice module for starting Jetty based rest server with Jersey
Apache License 2.0
40 stars 11 forks source link

Jetty dependency: upgrade to major version 10 or 11? #32

Open ztai-add opened 2 years ago

ztai-add commented 2 years ago

Hi,

I wonder if there's plan to upgrade the jetty dependency to version 10 or 11? The latest guice-jersey 1.0.16 depends on jetty version 9.4.28.v20200408 which has some vulnerability issues https://mvnrepository.com/artifact/io.logz/guice-jersey/1.0.16.

Thanks, Zhenfei

kdombeck commented 2 years ago

One problem that I have is that if I try to upgrade to Jersey 10.x in my project I get the following issue when I try to start Jetty.

Exception in thread "main" java.lang.NoSuchMethodError: 'void org.eclipse.jetty.webapp.WebAppContext.addEventListener(java.util.EventListener)'
    at io.logz.guice.jersey.JerseyServer.configureServer(JerseyServer.java:83)
    at io.logz.guice.jersey.JerseyServer.<init>(JerseyServer.java:46)
    at io.logz.guice.jersey.JerseyModule.configure(JerseyModule.java:37)
    at com.google.inject.AbstractModule.configure(AbstractModule.java:66)
    at com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:409)
    at com.google.inject.spi.Elements.getElements(Elements.java:108)
    at com.google.inject.internal.InjectorShell$Builder.build(InjectorShell.java:160)
    at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
    at com.google.inject.Guice.createInjector(Guice.java:87)
    at com.google.inject.Guice.createInjector(Guice.java:69)
...

Seems like the method signature in ServletContextHandler has changed to return a boolean rather than be void causing this issue.