search

logzio / guice-jersey

Guice module for starting Jetty based rest server with Jersey
Apache License 2.0
40 stars 11 forks source link

Add websockets feature #5

Closed ccremer closed 6 years ago

ccremer commented 6 years ago

Hi. I'm using guice-jersey in one of my projects and wanted to try websockets. Instead of initializing another jetty server and consuming twice the memory, I thought about integrating websockets into this project, so that a browser may receive updates without polling but still have a restful API for the request/response operations.

However there is a restriction on the context path, if websockets are enabled. This is described in the readme. Websockets will add another few of dependencies, even if disabled. I tried to make them optional, but I failed doing so. They are just a few hundred KBs, so it's not too bad.

The implementation is actually based on your project guice-websocket ;)

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-3.2%) to 90.11% when pulling 2c2c4a57e3b180b6b3e249f4a6e2286859c72a35 on ccremer:master into b35836b6ad268b680519215d0c20916d8d05aaf6 on logzio:master.

asafm commented 6 years ago

@ccremer would you like to continue working on this?

ccremer commented 6 years ago

Oh, I'm so sorry. I'm currently in the process of moving to my new apartment and I don't have time for anything else. And after that I've other plans, so I think that counts as a No for the time being...

asafm commented 6 years ago

@asafalima - I suggest closing this for now, opening an issue on this, tagged appropriately?