logzio / jmx2graphite

JMX to Graphite every x seconds in one command line (Docker based) (also come in Java Agent flavour)
MIT License
78 stars 23 forks source link

wrong entrypoint/cmd in Dockerfile #88

Open pikrzysztof opened 3 years ago

pikrzysztof commented 3 years ago

from docker inspect logzio/jmx2graphite:

            "Cmd": [
                "/bin/sh",
                "-c",
                "java -cp jmx2graphite.jar:slf4j-simple-1.7.25.jar io.logz.jmx2graphite.Jmx2GraphiteJolokia application.conf"
            ],

this results in /bin/sh having pid1 in the container and java pid >1.

on docker kill the signal gets passed to /bin/sh which exits, but java has no clue what happened and gets surprised with a SIGKILL 60 seconds later.

Can we please set the cmd to exec java -cp ... or use a proper init?

asafm commented 3 years ago

I don't have a lot of time lately. Would love help with PR on this.