search

logzio / logzio-docker

Forward all your Docker logs to Logz.io
Apache License 2.0
35 stars 17 forks source link

Use a single type for Docker events? #23

Open simonvanderveldt opened 5 years ago

simonvanderveldt commented 5 years ago

Currently the Docker events are published with different types (create, stop, die, etc). This is somewhat annoying to filter. Wouldn't it make more sense to use a single type (docker-events, similar to docker-stats) and publish the event that happened in for example an event field?

idohalevi commented 5 years ago

@simonvanderveldt Great feedback. We are working on a new integration that will be published in the next week or two. I'll make sure to solve this issue in it.

simonvanderveldt commented 5 years ago

@idohalevi Thanks for the quick response. Sounds good! If you ping/update this issue when you're ready we'll make sure to try out the new integration :)

simonvanderveldt commented 5 years ago

Just noticed that Docker's exec_start events have their type incorrectly defined as exec_start: <command that was run> instead of just exec_start, so they are all different. I assume this will also be covered/fixed by the new integration?

idohalevi commented 5 years ago

@simonvanderveldt Can you please add a snapshot example?

simonvanderveldt commented 5 years ago

@idohalevi two examples can be seen in this screenshot image

And from one specific message: image

idohalevi commented 5 years ago

@simonvanderveldt I'm pretty sure we will use a type per collector/docker in the new integration so it should be fixed. I'll double check it and if you see the same issue with the new one please let us know and we will work on it