search

logzio / logzio-logback-appender

Logback Appender that ships logs using HTTPs bulk
Apache License 2.0
25 stars 19 forks source link

add marker support #25

Closed gabriele83 closed 7 years ago

gabriele83 commented 7 years ago

Ok

Il 20 nov 2016 09:34, "Asaf Mesika" notifications@github.com ha scritto:

@asafm requested changes on this pull request.

Thanks for the addition! Can you please add the following:

  1. Bump version to 1.0.12
  2. Add a unit test testing marker support
  3. Add documentation in README explaining the support for markers (like

MDC has)

In src/main/java/io/logz/logback/LogzioSender.java https://github.com/logzio/logzio-logback-appender/pull/25#pullrequestreview-9359902 :

@@ -129,9 +130,9 @@ private LogzioSender(String logzioToken, String logzioType, int drainTimeout, in }

 public static synchronized LogzioSender getOrCreateSenderByType(String logzioToken, String logzioType, int drainTimeout, int fsPercentThreshold, String bufferDir,
  • String logzioUrl, int socketTimeout, int connectTimeout, boolean debug,
  • LogzioLogbackAppender.StatusReporter reporter, ScheduledExecutorService tasksExecutor,
  • boolean addHostname, String additionalFields, int gcPersistedQueueFilesIntervalSeconds) {
  • String logzioUrl, int socketTimeout, int connectTimeout, boolean debug,

If only spaces added, let's revert to the original indentation please, so

we can focus on what's been added

In src/main/java/io/logz/logback/LogzioSender.java https://github.com/logzio/logzio-logback-appender/pull/25#pullrequestreview-9359902 :

@@ -62,9 +63,9 @@ private final AtomicBoolean drainRunning = new AtomicBoolean(false);

 private LogzioSender(String logzioToken, String logzioType, int drainTimeout, int fsPercentThreshold, String bufferDir,
  • String logzioUrl, int socketTimeout, int connectTimeout, boolean debug,
  • LogzioLogbackAppender.StatusReporter reporter, ScheduledExecutorService tasksExecutor,
  • boolean addHostname, String additionalFields, int gcPersistedQueueFilesIntervalSeconds)
  • String logzioUrl, int socketTimeout, int connectTimeout, boolean debug,

If only spaces added, let's revert to the original indentation please, so we can focus on what's been added

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/logzio/logzio-logback-appender/pull/25#pullrequestreview-9359902, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJoNL30Jaa1NOlS9qM7-TUCvFNF5fTIks5rAAYVgaJpZM4K2prB .

gabriele83 commented 7 years ago

news?

gabriele83 commented 7 years ago

Thank you

Il 21 nov 2016 20:15, "Asaf Mesika" notifications@github.com ha scritto:

Merged #25 https://github.com/logzio/logzio-logback-appender/pull/25.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/logzio/logzio-logback-appender/pull/25#event-867074713, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJoNOEIHro-VCOlyy47pWKfiPt2jgsxks5rAe3cgaJpZM4K2prB .

gabriele83 commented 7 years ago

when it will be updated on the maven central?

roiravhon commented 7 years ago

@gabriele83 just pushed, can take up to 2 hours to propagate. Thanks for that PR!

gabriele83 commented 7 years ago

Tks

Il 22 nov 2016 09:56, "Roi Rav-Hon" notifications@github.com ha scritto:

@gabriele83 https://github.com/gabriele83 just pushed, can take up to 2 hours to propagate. Thanks for that PR!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/logzio/logzio-logback-appender/pull/25#issuecomment-262182901, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJoNN8EfAyAxvvezJ_XrhWBbhCZZh1Dks5rAq5EgaJpZM4K2prB .