search

logzio / logzio-logback-appender

Logback Appender that ships logs using HTTPs bulk
Apache License 2.0
25 stars 19 forks source link

Remove SLF4j from uber-jar file, but keep it in dependencies #71

Closed klya closed 3 years ago

klya commented 4 years ago

SLF4j from logzio-appender clashes with the original library which has different version. This change fix it.

Here is example of this problem with logs: https://github.com/logzio/logzio-logback-appender/issues/20#issuecomment-357711853.

yyyogev commented 4 years ago

@klya thanks for your suggestion. We'll review it shortly

yyyogev commented 3 years ago

Looks good @klya , please remove the comment and we are good to go

klya commented 3 years ago

@yyyogev done!