search

logzio / logzio-logback-appender

Logback Appender that ships logs using HTTPs bulk
Apache License 2.0
25 stars 19 forks source link

Correct shading, so there is a single remaining dependency: logback #80

Closed ls-urs-keller closed 2 years ago

ls-urs-keller commented 3 years ago

We had issues with duplicate classes, since the shading is not correct and the shaded dependencies were not removed from the published pom.xml.

With the changes this produces an artifact without having the risk of duplicate classes and the reduced pom.xml will look like this.

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>io.logz.logback</groupId>
  <artifactId>logzio-logback-appender</artifactId>
  <version>0-SNAPSHOT</version>
  <licenses>
    <license>
      <name>The Apache License, Version 2.0</name>
      <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
    </license>
  </licenses>
  <dependencies>
    <dependency>
      <groupId>ch.qos.logback</groupId>
      <artifactId>logback-classic</artifactId>
      <version>1.2.3</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>
</project>
yotamloe commented 3 years ago

Hey @ls-urs-keller, thank you for contributing, we will go over this PR soon, and will keep you updated.