search

logzio / sawmill

Sawmill is a JSON transformation Java library
Apache License 2.0
116 stars 24 forks source link

PipelineExecutor does not allow to close internal resources #172

Closed grnadav closed 5 years ago

grnadav commented 5 years ago

Hi

We recently started using Sawmill, and noticed a thread leak issue. We tracked it down to creation of multiple instances of PipelineExecutor s - It internally allocates a watchdog, which allocates an Executor, but the PipelineExecutor does not expose a close method to close it when done.

I created a (very small) pull request w/ a fix: https://github.com/logzio/sawmill/pull/171

Thanks

oririechman commented 5 years ago

Merged! Thanks!