search

logzio / sawmill

Sawmill is a JSON transformation Java library
Apache License 2.0
116 stars 24 forks source link

IpCompareCondition.java #259

Closed jgreen117 closed 2 years ago

jgreen117 commented 2 years ago

Removed the requested commented lines

barakm commented 2 years ago

Hi @jgreen117 , Looks like you created a new PR rather than updating the existing one. Please choose which one is relevant and close the other one. Remember that you can rebase your old branch from the current main branch and then update the PR. This will make sure your PR is based on the most recent code.

As for a full review, @DanMelman should have a look.

jgreen117 commented 2 years ago

@barakm got it. Sorry couldn't figure out how to edit a pull request without opening a new one. Closed the old one

DanMelman commented 2 years ago

Hi @jgreen117, should this PR be merged to your other branch or to master? it currently contains only 4 deleted comment lines. image

barakm commented 2 years ago

Hi @jgreen117 , Looks like you are continuing this work in https://github.com/logzio/sawmill/pull/258, so I am closing this PR for now. If the code here is still relevant, consider merging it to the other PR.