search

lohsuan / puppy_sponsor

Frontend and smart contract for puppy sponsor web3.0 project.
MIT License
1 stars 3 forks source link

Add the `point-back` feature #8

Closed lohsuan closed 2 years ago

lohsuan commented 2 years ago

Description

As title

How to verify

  1. import token in meta mask
    • 0xFD63AC01eb9D85a5fbdB5E669BE4D7CA7136f29d
    • image
  2. donate
tzulin commented 2 years ago

Okay. Just a minute.

tzulin commented 2 years ago

Okay

Xanonymous-GitHub commented 2 years ago

Warning Later, I checked the ERC20 standard and found that many methods are required to be declared as public instead of external, so I think it is necessary for us to check again whether the contract interface fully conforms to the ERC20 standard.

https://ethereum.org/en/developers/docs/standards/tokens/erc-20/ https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/IERC20.sol

I haven't thought deeply about this a while ago, and I'm very, very sorry for the useless advice (https://github.com/lohsuan/puppy_sponsor/pull/8/files#pullrequestreview-1008733848).... 😢😢😢😢😢😢😢😢😢😢😢😢😢😢😢😢😢😢😢😢

So that means we should check the standard again, and(maybe) change some methods from external to public.