search

loicgasser / quantized-mesh-tile

Quantized-Mesh encoder/decoder and topology builder
MIT License
89 stars 20 forks source link

Adding TileStitcher as optional postprocessing tool #26

Closed thiloSchlemmer closed 6 years ago

thiloSchlemmer commented 6 years ago

For now, performance of TileStitcher is stabilized at factor 0.3 (3 times faster) of previous pull request. Test-resources reduced and simplified, TestCoverage closer on the level of the master-branch

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.5%) to 93.045% when pulling e5bd1e4fdcae333b08b45d4c8a4dc6700ec1910c on thiloSchlemmer:master into 31a0560ace0b8a611cb316e9f9c4bc101ad5848b on loicgasser:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.5%) to 93.045% when pulling e5bd1e4fdcae333b08b45d4c8a4dc6700ec1910c on thiloSchlemmer:master into 31a0560ace0b8a611cb316e9f9c4bc101ad5848b on loicgasser:master.

loicgasser commented 6 years ago

Thank you for the effort! I will have a look at it as soon as possible. Still think we would be better of doing it during the tile creation, but this could solve a lot of use cases so I will defenetly take the time to review. Don't hesitate to add some doc!

loicgasser commented 6 years ago

Also we should mark it as experimental in the code doc if possible.

loicgasser commented 6 years ago

Are you familiar with git rebase? Try to cleanup a bit the commit history and remove my commits.

https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

thiloSchlemmer commented 6 years ago

Hi loic

i have reset my fork, as rebasing seems to be more complicate and all the polluting commits of mine don't give any additional value. I'm not enough experienced in rebasing so commiting my changes to a fresh fork was easier, the new pull request will follow.

After holiday i will add some doc.