loicginoux / joanne_project

joanne's project
2 stars 1 forks source link

Stats for Daily Email #310

Closed jdaudier closed 11 years ago

jdaudier commented 11 years ago

Can we add something like this for the daily email? Check www.codecademy.com to see it.

Points chart for: YESTERDAY BEST (most points earned in 1 day) TOTAL (points earned for the month)

Streaks: Days in a row you've posted photos Personal best streak

pts

jdaudier commented 11 years ago

And a progress bar for the week. Each day will light up when you've posted a photo. Text can say: You've posted photos X days out of the 7.

Progress bar can look something like this... Sun

This is how Codecademy does it: streaks

loicginoux commented 11 years ago

Hi, Ok I would have to rework the way I calculate points. At the moment, points is just a field in the user table in the database. I will need to create a model Point, to be able to store the date points get added. This will allow to manipulate points more easily.

jdaudier commented 11 years ago

Do you think that'll be complicated?

loicginoux commented 11 years ago

This is the feature you want as soon as possible, right? We need to define a bit more what you want. I am ok with the part about the points but don't you think that the streaks and the progress bar bring the same information twice? Also where should we put this in the email?

jdaudier commented 11 years ago

Yes. The streaks is a bit different from the progress bar because the bar looks at it from a weekly point of view. And for streaks, you can have a 13 day streak for example.

I think we can put this either at the very top starting with the progress bar perhaps, followed by streaks, then points. What do you think?

loicginoux commented 11 years ago

Ok, I will add that on top. Do you prefer me to work on the few bugs that come up first or this?

jdaudier commented 11 years ago

Bugs first please

loicginoux commented 11 years ago

Ok I work on them now

loicginoux commented 11 years ago

I finished bugs for now, I am working on that.

loicginoux commented 11 years ago

FYI, streaks will be calculated at midnight for each user's local time. at this time, I will see if a photo has been uploaded for the day and readjust streak and best streak. Said this, note that if a photos is edited and his time changed to a previous day, streaks will not be updated as it will have already been calculated.

jdaudier commented 11 years ago

If I only uploaded 1 photo today and set is as yesterday's photo, it won't count in my streak for today. Did I understand it correctly?

loicginoux commented 11 years ago

just to have our minds clear, a photo contains 3 date fields:

Now, your comment made me think. I was going to use the "uploaded_at" date to calculate streaks but as your suggested, It might be more accurate to calculate streaks based on "created_at" date. This way, in your example:

"If I only uploaded 1 photo today and set is as yesterday's photo,"

It will count on your streak for today and not for yesterday.

Is that clearer?

loicginoux commented 11 years ago

another thing about points, The best points earned in a day will start only from the date I put that live. I won't be able to calculate it for the past days as I currently can't tell when points have been awarded.

jdaudier commented 11 years ago

OK makes sense to calculate streaks based on "created_at" date. So as long as you upload a photo today, it doesn't matter which day you set it as.

Agreed regarding most points earned in a day.

loicginoux commented 11 years ago

I will also update the app with this changes just before the end of the month. I do this because when I will update, the monthly leaderboard points will be wrong and be equal to the total leadeboard points. When the next month starts , monthly points will be calculated as before.

jdaudier commented 11 years ago

The heading for this new email section can be: Your stats

loicginoux commented 11 years ago

was the progress bar in an email or in a webpage? Could I access the page or could you forward me the email to inspect the code? I am saying that because f you want it this way I will probably need the images? I could redo it in photoshop but that would be longer.

jdaudier commented 11 years ago

Which progress bar? I have 2 examples above.

loicginoux commented 11 years ago

I was thinking of using the first one with the days. I will light up the previous day you've posted photos. I don't really think the second one fit in to display days you've uploaded photos.

loicginoux commented 11 years ago

I have this at the moment, but I would like to add images to the progress bar if possible. http://awesomescreenshot.com/03716r1n79

jdaudier commented 11 years ago

Add images to the progress bar? Can you explain?

Above the bar, can we add this text: You've posted photos X days out of 7.

For the first box under points, should it say: YESTERDAY

loicginoux commented 11 years ago
jdaudier commented 11 years ago

Oh I see. I just have the illustrator files for the images. That probably won't help you, right?

I'm super excited about these new stat features.

jdaudier commented 11 years ago

One idea if you want to try is... adding a circle inside the orange square kinda like the FoodRubix logo. So the letter will be surrounded by a lighter orange circle and the square orange can be darker to match logo.

loicginoux commented 11 years ago

Yes that will do with the illustrator file. If you ok to make it fancier, just send me the file and I will extract the images and add it to the progress bar.

jdaudier commented 11 years ago

Do you think we should try using the orange logo part so it looks like a little camera for each day?

jdaudier commented 11 years ago

I guess we can keep it simple for now and leave it like how to have it. And we can make it fancier later.

loicginoux commented 11 years ago

Ok I leave it like this for now. Another question about the progress bar. Is it based on the date "created_at" or "uploaded_at"? Said in another way, does a day light up when you sent a photo or when you have a photo displayed in your diary for this day? I would say based on the fact that you sent a photo to the app ("created_at"), so that it corresponds with the streaks.

jdaudier commented 11 years ago

Agreed.

loicginoux commented 11 years ago

Hello Joanne, I have deployed this changes on the testing server. I will leave it there for few days, time to test that emails content are correct. You should activate your daily email on the testing server to check it as well. The whole point system has changed as well so you now have a way to track points in the admin panel.

jdaudier commented 11 years ago

Does that mean I have to post images on the staging site for the email stats to work?

loicginoux commented 11 years ago

no it will work but you won't have any light in the progress bar neither streaks/points.

jdaudier commented 11 years ago

Just to confirm, if I upload photos on Mon and Tue, the progress bar boxes for Mon and Tue will both be lit in orange, correct?

loicginoux commented 11 years ago

yes

On 25 April 2013 08:10, jdaudier notifications@github.com wrote:

Just to confirm, if I upload photos on Mon and Tue, the progress bar boxes for Mon and Tue will both be lit in orange, correct?

— Reply to this email directly or view it on GitHubhttps://github.com/loicginoux/joanne_project/issues/310#issuecomment-16990242 .

jdaudier commented 11 years ago

I was trying to set a daily calorie goal on the staging site but it says "you can't do that".

loicginoux commented 11 years ago

I can't replicate this and can't see what's happening in logs.

jdaudier commented 11 years ago

Still not working using the latest Chrome browser.

Here's a video: http://screencast.com/t/pJGxZj6m6C3

jdaudier commented 11 years ago

Can you make the font size bigger for this line? :-) = You stayed within your daily calorie limit

jdaudier commented 11 years ago

When you don't have the daily calorie goal set, the Goal Check section should have the SAMPLE stamp. I think right now it thinks my calorie limit = 0 cal.

sample

loicginoux commented 11 years ago

On Sunday, we need to display the past week and not the current week on the progress bar.

jdaudier commented 11 years ago

Can we add commas here too? 2013-05-11_1623

loicginoux commented 11 years ago

this is done: "On Sunday, we need to display the past week and not the current week on the progress bar."

loicginoux commented 11 years ago

timezone issue should be fixed for the progress bar now.

jdaudier commented 11 years ago

Can we add some bottom margin below the progress bar? This is how it look in Outlook. 2013-05-15_0750

loicginoux commented 11 years ago

This has been done, correct?