loicginoux / joanne_project

joanne's project
2 stars 1 forks source link

Compare last week's calorie feature in the chart #335

Closed jdaudier closed 11 years ago

jdaudier commented 11 years ago

Would it be hard to have a "COMPARE" button in the weekly view (on the site) that lets you pull up last week's data and compare that against this week's similar to Google Analytics?

When you press the COMPARE button, it will draw 2 lines to compare this week with previous week. Like Google Analytics. I think we can do this just for the weekly view first.

GA

jdaudier commented 11 years ago

Is it hard to add the compare feature to month view so you can compare last month to this month?

loicginoux commented 11 years ago

I will see if the graphic library allows me to compare easily if there is not exactly the same amount of data ( 30 days compared to 31)

On 29 April 2013 05:13, jdaudier notifications@github.com wrote:

Is it hard to add the compare feature to month view so you can compare last month to this month?

— Reply to this email directly or view it on GitHubhttps://github.com/loicginoux/joanne_project/issues/335#issuecomment-17148556 .

loicginoux commented 11 years ago

where do you think the button should go? http://awesomescreenshot.com/01718m7g96

jdaudier commented 11 years ago

I like it here. You? 2013-05-05_1348

loicginoux commented 11 years ago

Agreed

loicginoux commented 11 years ago

This is the current graphic for the month view http://awesomescreenshot.com/0d7190xe0d

and the graphic when comparing 2 months: http://awesomescreenshot.com/038190wj59

As you can see on the graphic on the X-axis, each point correspond to a particular date and not a day number The problem is that when comparing 2 months, the lines don't superpose. 2 solutions:

Is the solution 2 ok with you?

jdaudier commented 11 years ago

I think the lines have to superpose like Google Analytics for it to be useful.

How would this look like? for each points, on the X-axis we will only be showing a number between 1 and 31. The X-axis will not show the month anymore, only the day number, but when comparing, the two lines will superpose.

jdaudier commented 11 years ago

Can we make the COMPARE button orange so it stands out?

loicginoux commented 11 years ago

Ok, As I was on the graphic I changed his look a bit. here is the comparison for the week view: http://awesomescreenshot.com/05e192bd06 I will push the current state on staging site at the end of the day.

jdaudier commented 11 years ago

That looks great! Can we add a bit of white margin below the compare button so it's not touching the chart?

loicginoux commented 11 years ago

This is deployed on testing site as well as last weekly and daily emails.

loicginoux commented 11 years ago

compare button is now with a toggle state in staging site.

jdaudier commented 11 years ago

Can we change the text on the button to say: Compare to Last Week Remove Comparison

loicginoux commented 11 years ago

ok

jdaudier commented 11 years ago

Updated: Compare to Last Week

loicginoux commented 11 years ago

changed in testing