loicland / cut-pursuit

C++ implementation for the cut pursuit algorithm, with Matlab interfaces
MIT License
77 stars 24 forks source link

Compilation error #18

Closed tkucner closed 5 years ago

tkucner commented 5 years ago

Hi, I am trying to compile your software. I got the following error:

/home/tzkr/python_workspace/cut-pursuit/src/cutpursuit.cpp: In function ‘PyObject* cutpursuit_seg(const boost::python::numpy::ndarray&, const boost::python::numpy::ndarray&, const boost::python::numpy::ndarray&, const boost::python::numpy::ndarray&, float)’:
/home/tzkr/python_workspace/cut-pursuit/src/cutpursuit.cpp:90:80: error: no matching function for call to ‘cut_pursuit(const uint32_t&, const uint32_t&, const uint32_t&, const float*&, const uint32_t*&, const uint32_t*&, const float*&, __gnu_cxx::__alloc_traits<std::allocator<float> >::value_type*, float*, std::vector<unsigned int>&, std::vector<std::vector<unsigned int> >&, float&, float, float, float)’
              , solution.data(), in_component, components, lambda, 1.f, 2.f, 2.f);

Do you have any idea how to fix it?

loicland commented 5 years ago

Hi,

I forgot to update the wrapping functions. It should be fixed with the latest commit.

tkucner commented 5 years ago

Great! I am looking forward to the next commit!

loicland commented 5 years ago

Should be good with commit 6e6ee14e62f1882f2a49e37ddb65ef26cecfd721

Works for you?

tkucner commented 5 years ago

I might be doing something wrong, but as far as I understand the problem is with cutpursuit.cpp. In the commit that you are pointing at the cutoff parameter is not used in cutpursuit.cpp.

loicland commented 5 years ago

My bad, should be fixed now.

tkucner commented 5 years ago

Yes, thank you!