search

loicleyendecker / deeppath

MIT License
5 stars 4 forks source link

Allow dget to use any mapping as input #6

Closed 1Mark closed 2 years ago

1Mark commented 2 years ago

I think you need to specify the types for Mapping and MutableMapping. Maybe mypy doesn't complain with the current settings but it definitely would in strict mode.

Are you sure? I tested with strict mode and it didn't complain, also MutableMapping inherits from Mapping, regardless, we shouldn't limit this to MutableMapping only.