search

loicpennequin / convex-vue

MIT License
13 stars 6 forks source link

Types point to incorrect file #6

Closed ssorallen closed 6 months ago

ssorallen commented 6 months ago

After doing npm install @convex-vue/core it looks as if the package is pointing to the incorrect type file.

Structure in node_modules after install:

Screenshot 2024-03-11 at 6 00 28 PM

Attempt to import from "@convex-vue/core":

Screenshot 2024-03-11 at 6 00 18 PM

File that opens with Cmd+click on the "@convex-vue/core" import:

Screenshot 2024-03-11 at 6 00 38 PM

The correct file appears to be one level up inside dist/.

loicpennequin commented 6 months ago

Hi, thank you for noticing ! I updated the package.json to point to the correct path for the types declarations, it should work properly now.

However I'm a bit confused because it already worked for me before (I got correct types and ctrl+clicking took me to the correct file).

ssorallen commented 6 months ago

@loicpennequin Strange, had you been doing npm link to test the package maybe? I'll try switching to the NPM package now. So far we have been using this repo as a submodule but an NPM package will be great instead.

ssorallen commented 6 months ago

This looks good in v0.0.3. Closing this one.