search

loicsander / Robofont-scripts

MIT License
68 stars 28 forks source link

remove a 'mode' in a filter #12

Closed thomgb closed 9 years ago

thomgb commented 9 years ago

Are you able to remove the boolean once a filter has one? The whole extension explodes when I try... :)

loicsander commented 9 years ago

I can’t seem to reproduce this problem, could you provide some more details, how many filters in the group, using pens or functions?

thomgb commented 9 years ago

Find here my pens/filters

For the test a used:

This filter give a aura-spikey effect. :)

Then I double click 'difference' and delete the word. Whatever I do next, it no good. I can close the window and reopen the extension. Then the damage will be clearly visible... The list is not there and the SpaceCenter empty or messed up...

The moment I hit enter when I remove difference. The output window pops up but no message.

screens for the damage: screen shot 2015-05-02 at 18 25 00 screen shot 2015-05-02 at 18 24 46

hope it helps :)

loicsander commented 9 years ago

Thanks for the details, I’ll look into this.

loicsander commented 9 years ago

Okay, this is weird, I tried your setup, and changed the mode, everything went fine.

capture d ecran 2015-05-02 a 18 50 55

thomgb commented 9 years ago

Alright, maybe its my system. I use OS 10,10,3.

loicsander commented 9 years ago

I’ve modified a number of things internally, maybe these fixes solved the issue. You can try with the last version. If the issue remains, then it’s linked to something else, maybe your system yes. We can still try to figure out what the problem is.

thomgb commented 9 years ago

Great! I look tomorrow! :) Thanks.

loicsander commented 9 years ago

Also, you can achieve the same result by doing this:

Filter group: – Spike, mode:None, initial:False – copy, mode:union, initial:True

I added a base ‘copy’ filter, so you copy the initial glyph and make a ‘union’ boolean operation on the spiked glyph.

thomgb commented 9 years ago

I have still the same trouble with removing 'mode'.

Also now I unable to make groups. as soon as the Ext. is close there gone. You want this issue in a new issue? :) Sorry for finding all these errors ;)

loicsander commented 9 years ago

Oh, I see what went wrong with groups, this is solved now.

As for the mode crashing things, It’s rather annoying that there’s no traceback, it makes it really hard to have an idea of what’s messing up Robofont.

Does it happen when you change the mode without regard to what you put in the cell or does it react badly only to mode removal?

thomgb commented 9 years ago

Changing the mode is fine. I looked into the code where the editing of the mode is, but I couldnt find it. Can you tell me where to look?

loicsander commented 9 years ago

Modes are gathered there: https://github.com/loicsander/Robofont-scripts/blob/master/PenBallWizard/PenBallWizard.roboFontExt/lib/penBallWizard.py#L415

But I’m not sure it will be of much help. Meanwhile, I’ve modified the way boolean operations are handled to catch errors. If I succeeded, you may not get the crashes anymore but an errorGlyph telling you a boolean operation went wrong (B). I’ve stumbled upon issues with booleanOperations as well, but one must remember that such geometry calculations are prone to all kind of mishaps, it’s complicated stuff.

But there’s another issue with modes and with arguments in general, they don’t get updated right away if you change them, you need to restart the extension or sometimes even Robofont to see the change taking effect…