search

loicteixeira / gj-unity-api

[MOVED] Game Jolt API wrapper for Unity.
https://github.com/InfectedBytes/gj-unity-api/
MIT License
16 stars 13 forks source link

add remember me functionality, encryption of user credentials #81

Closed InfectedBytes closed 7 years ago

InfectedBytes commented 7 years ago

This PR adds a remember me toggle to the sign in window (issue #18 ). If checked, the user's credentials are stored in PlayerPrefs (encrypted with XTEA). If the game is restarted and the sign in window is shown, it will automatically fill in the user's credentials. Depending on an additional boolean parameter, it will automatically log the user in.

loicteixeira commented 7 years ago

Great work again. I like the no dependencies approach.

As discussed on the issue, the more secure the better, but it doesn't have to be the most secure either, therefore XTEA should be alright (although my knowledge on that field is limited).

Comments are mostly around the behaviour of the functionality which my issue didn't really explain that much. I'll try to go through the issues and comment more clearly about it now that I'm not the only one working on it.

InfectedBytes commented 7 years ago

Ready to merge.

Before we create a new release, I would first modify the folder structure a bit, so we could release it also on the Asset Store. I'll write some more info in the corresponding issue.