loicym / multibreak

Implements the multivariate time series break detection of Bai, Lumsdaine and Stock (1998)
MIT License
2 stars 4 forks source link

ggplot Error #1

Open lnsongxf opened 3 years ago

lnsongxf commented 3 years ago

Hi,

I test your program with the data you provided "gsci_group.csv", and I get the following message, which I believe is ggplot error. "Error in seq.int(0, to0 - from, by) : 'to' must be a finite number"

Thanks for your great work.

Best,

Mark Song

loicym commented 3 years ago

Dear Mark,

Many thanks for your email, and for pointing this issue to me. I am going to check it by next week and come back to you as soon as I can. Thanks for your patience and have a good day.

Kind regards,

Loïc

Le lun. 5 avr. 2021 à 18:21, Mark Song @.***> a écrit :

Hi,

I test your program with the data you provided "gsci_group.csv", and I get the following message, which I believe is ggplot error. "Error in seq.int(0, to0 - from, by) : 'to' must be a finite number"

Thanks for your great work.

Best,

Mark Song

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/loicym/multibreak/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMLKX53T3RJYKHN5HV6ZDELTHHPPFANCNFSM42NB3YCQ .

-- Loïc Maréchal PhD candidate and visiting lecturer University of Neuchâtel

loicym commented 3 years ago

Dear Mark,

I have pushed a new version of the code, which is more aligned with the coding standards. I tried it and I have not obtained your error message. Could you retry it, maybe using the "Simul" function to generate simulated data that behave better than the csv file?

You could use:

data.simul <- Simul() with the default parameters, and then pass it to the main function with: Main(mat.y = data.simul) Let me know if this doesn't work.

Kind regards,

Loïc

lnsongxf commented 3 years ago

Thanks, Loïc, I will try it.

Thank you for your efforts to make everything great.

Best,

Mark