loitho / katello-create-errata

Create Errata repository for Katello
1 stars 1 forks source link

Ability to add credentials for s3 #1

Open MaxDiOrio opened 1 year ago

MaxDiOrio commented 1 year ago

The concept is great, however your setup assumes that either the container created has direct access to s3 via IAM based service accounts, or that the bucket is wide open read/write. There is currently no way to pass in credentials into the 'aws s3' command.

loitho commented 1 year ago

Hi, That's correct, although you can run the container by itself if you comment the end of the file. The container is a Nginx server by itself.

Feel free to make a PR if you wish to incorporate the possibility to use credentials :)

MaxDiOrio commented 1 year ago

Hi!

I ended up forking your project and setting it up to be a Kubernetes CronJob that passes in the credentials and S3 URI as environment variables via a K8S Secret.

Thanks for providing the base!