search

lokalise / lokalise-cli-2-go

Lokalise CLI v2
Other
108 stars 52 forks source link

Adopt SemVer #35

Closed balloob closed 4 years ago

balloob commented 4 years ago

It would be great if this CLI would adopt Semantic Versioning for its versioning. That way it would make it easier for Home Assistant to stay up to date.

With Semantic Versioning, if you make a breaking API change (ie change a command line flag), you would bump a major version. That way consumers of your CLI that are upgrading know they need to look at the release notes.

Recent changes that were breaking:

nickustinov commented 4 years ago

Thanks for the advice, however we decided to keep it at major version 2, as it's CLIv2, which works over APIv2 and the binary is called lokalise2. It would be irrational to rename it all at this point. We will switch to semantic versioning and different naming with a more global update.

balloob commented 4 years ago

Would it be possible to adopt an adapted version ? So make breaking changes when you go to 2.6, 2.7, but not when you go from 2.6.0 to 2.6.1 ? That way you can keep your 2 in the version number?

beinarovic commented 4 years ago

2.5.1 was a first day patch, the ‘—pool’ flag was introduced in 2.5.0 the same day. Otherwise we would bump a minor version.