lokalise / lokalise-cli-2-go

Lokalise CLI v2
Other
108 stars 52 forks source link

Incorrect upload file on version v2.5.1 via docker image #36

Closed IASamoylov closed 4 years ago

IASamoylov commented 4 years ago

After upgrading to version 2.5.1, template strings do not load correctly.

Exmaple:

{
    "bug": {
        "test_key": "Possible bug in {bugDescription}"
    }
}

Version 2.3.0:

image

Version 2.5.1:

image

beinarovic commented 4 years ago

Hello.

We had an inconsistency in the cli flags. Cli has --convert-placeholders=false by default, but the. api's default was true.

In 2.5.0 we have changed the default to --convert-placeholders=true.

https://github.com/lokalise/lokalise-cli-2-go/releases/tag/v2.5.0

IASamoylov commented 4 years ago

@beinarovic hello.

I get the same result when --convert-placeholder is true and false.

docker run --net=host --rm -v $($volume):/opt/src/en.json lokalise/lokalise-cli-2:2.5.1 lokalise2 --token $($token) --project-id $($projectId) file upload --replace-modified --file /opt/src/en.json --lang-iso en --convert-placeholders true --poll

image

beinarovic commented 4 years ago

@IASamoylov The correct flag would be --convert-placeholders=false in your case.

beinarovic commented 4 years ago

The default was false before... And bool flags should be passed with = separator.

IASamoylov commented 4 years ago

@beinarovic thank you, this is working

beinarovic commented 4 years ago

No problem, have a nice day!