phpunit/phpunit requirement?

lokalise / php-lokalise-api

Lokalise API v2 PHP library.

https://app.lokalise.com/api2docs/curl/

MIT License

16 stars 11 forks source link

phpunit/phpunit requirement? #1

Closed keradus closed 6 years ago

keradus commented 6 years ago

Why there is phpunit/phpunit requirement if there are no tests? :(

andrewi-wd commented 6 years ago

Its under dev requirements. We are planning to add some basic tests.

keradus commented 6 years ago

dev or not, still a requirement. ah, i just got note from lokalise that it's developed, finished, public for usage. now you say it's still under development. as without tests, hard to trust it works properly.

nickustinov commented 6 years ago

Phpunit Is under requirement if you are using require-dev. It is not under requirement if you are using release version.

keradus commented 6 years ago

to sum up:

you put random packages to your composer.json file
there are no tests
you released API v2 and pointed out to ppl to start using this package

guy who dared to visit the package and review it before using it raised a concern...

nickustinov commented 6 years ago

Sorry I am not getting your point. The package is stable, it is just a simple curl wrapper for accessing the API which has all tests. The response was we are still planning to add simple tests here in near future, that is why there is dev version which is still wip.

If you are concerned there are no tests (yet) for the release version of this api wrapper, please do not use it.