Do not use "list" as method name

lokalise / php-lokalise-api

Lokalise API v2 PHP library.

https://app.lokalise.com/api2docs/curl/

MIT License

16 stars 11 forks source link

Do not use "list" as method name #24

Open jeremiegrenier opened 2 years ago

jeremiegrenier commented 2 years ago

All classes in the "API" namespace have a method named "list".

This causes an error lower to PHP5.6: Tag 3.0.0 is allowed to work with php5.6 but have "list"

PHP Parse error:  syntax error, unexpected 'list' (T_LIST), expecting '('

Because "list" is a keyword in PHP, it could not be used as a method name.

See Documentation

TheLevti commented 2 years ago

php 5.6 moved long ago to end of life. See: https://www.php.net/supported-versions.php. Please move on, there is no benefit to keep supporting such old versions, rather a slow down of progress.

If the maintainer is up for that, submit a pull request based on 3.1.0 to push a legacy release 3.x.x?