Fixed merging of empty results in requestAllUsingCursor()

lokalise / php-lokalise-api

Lokalise API v2 PHP library.

https://app.lokalise.com/api2docs/curl/

MIT License

16 stars 11 forks source link

Fixed merging of empty results in requestAllUsingCursor() #34

Open ureimers opened 5 months ago

ureimers commented 5 months ago

This PR fixes https://github.com/lokalise/php-lokalise-api/issues/33.

\Lokalise\Endpoints\Endpoint::requestAllUsingCursor() was overwriting previous results if the Lokalise API returned a cursor but the next result page didn't include any results.

anthonytournier commented 1 month ago

Hello @lokalise-engineering, could you please approve this PR? This bug is affecting us as well, and we had to downgrade to a previous version.