feat(AP-5236): Introduce metrics utils app package

lokalise / shared-ts-libs

Shared TypeScript libraries

Apache License 2.0

2 stars 1 forks source link

feat(AP-5236): Introduce metrics utils app package #354

Closed Drodevbar closed 1 week ago

Drodevbar commented 1 week ago

Changes

Introduces the metrics-utils package to make working with Prom metrics easier and more standardized.

Checklist

[x] Apply one of following labels; major, minor, patch or skip-release
[x] I've updated the documentation, or no changes were necessary
[x] I've updated the tests, or no changes were necessary

Drodevbar commented 1 week ago

@kibertoad It looks like the addition of a new package somehow conflicts with deps of another one (context-fastify-plugins) - https://github.com/lokalise/shared-ts-libs/actions/runs/11382381650/job/31665741626 I'll investigate. Sharing with you now in case you have some bright ideas how to solve it.

kibertoad commented 1 week ago

@Drodevbar probably not strictly enough pinned deps are messing things up. I can check in an hour or so

Drodevbar commented 1 week ago

@kibertoad I see it's fastify-metrics which requires fastify bo be >= 5 (as part of metrics-utils), while context-fastify-plugins only works with fastify v4. Do you think we should update fastify-plugins to work with v5 of fastify or use package aliases, workspaces, etc.?