search

lokedhs / gnu-apl-mode

GNU APL mode for Emacs
GNU General Public License v3.0
94 stars 18 forks source link

Clobbering of user-reserved keybindings #18

Closed larsbrinkhoff closed 7 years ago

larsbrinkhoff commented 7 years ago

GNU APL Mode adds a keybinding for C-c r:

https://github.com/lokedhs/gnu-apl-mode/blob/2118e0ef1aabecd2745709ad0eb9e4a1129ce9d4/gnu-apl-mode.el#L230

This is contrary to Emacs conventions:

Don’t define C-c letter as a key in Lisp programs. Sequences consisting of C-c and a letter (either upper or lower case) are reserved for users; they are the only sequences reserved for users, so do not block them.

https://www.gnu.org/software/emacs/manual/html_node/elisp/Key-Binding-Conventions.html

lokedhs commented 7 years ago

Point taken. Most of the keybindings chosen are pretty bad in fact.