search

lokedhs / gnu-apl-mode

GNU APL mode for Emacs
GNU General Public License v3.0
94 stars 19 forks source link

Symbol's definition is void: parse-integer #2

Closed danlei closed 10 years ago

danlei commented 10 years ago

In Emacs 24.3.50, following head (SHA: 6b49f2d at the time of writing, but probably introduced quite a bit earlier), after invoking gnu-apl:

Debugger entered--Lisp error: (void-function parse-integer)
  (parse-integer addr)
  (open-network-stream "*gnu-apl-connection*" nil "localhost" (parse-integer addr) :type (quote plain) :return-list nil :end-of-command "\n")
  (cond ((string= connect-mode "tcp") (open-network-stream "*gnu-apl-connection*" nil "localhost" (parse-integer addr) :type (quote plain) :return-list nil :end-of-command "\n")) (t (error "Unexpected connect mode: %s" connect-mode)))
  gnu-apl--connect-to-remote("tcp" "7293")
[…]

Fix:

Use string-to-number:

diff --git a/gnu-apl-network.el b/gnu-apl-network.el
index a20bb64..f366232 100644
--- a/gnu-apl-network.el
+++ b/gnu-apl-network.el
@@ -4,7 +4,7 @@

 (defun gnu-apl--connect-to-remote (connect-mode addr)
   (cond ((string= connect-mode "tcp")
-         (open-network-stream "*gnu-apl-connection*" nil "localhost" (parse-integer addr)
+         (open-network-stream "*gnu-apl-connection*" nil "localhost" (string-to-number addr)
                               :type 'plain
                               :return-list nil
                               :end-of-command "\n"))
lokedhs commented 10 years ago

You are right of course. parse-integer was picked up from calendar.el of all things.

I've committed a fix. Thanks for the feedback.

Regards, Elias

On 14 January 2014 04:01, Daniel H. Leidisch notifications@github.comwrote:

In Emacs 24.3.50, following head (SHA: 6b49f2dhttps://github.com/lokedhs/gnu-apl-mode/commit/6b49f2dat the time of writing, but probably introduced quite a bit earlier), after invoking gnu-apl:

Debugger entered--Lisp error: (void-function parse-integer) (parse-integer addr) (open-network-stream "gnu-apl-connection" nil "localhost" (parse-integer addr) :type (quote plain) :return-list nil :end-of-command "\n") (cond ((string= connect-mode "tcp") (open-network-stream "gnu-apl-connection" nil "localhost" (parse-integer addr) :type (quote plain) :return-list nil :end-of-command "\n")) (t (error "Unexpected connect mode: %s" connect-mode))) gnu-apl--connect-to-remote("tcp" "7293") […]

Fix:

Use string-to-number:

diff --git a/gnu-apl-network.el b/gnu-apl-network.el index a20bb64..f366232 100644 --- a/gnu-apl-network.el +++ b/gnu-apl-network.el @@ -4,7 +4,7 @@

(defun gnu-apl--connect-to-remote (connect-mode addr) (cond ((string= connect-mode "tcp")

  • (open-network-stream "gnu-apl-connection" nil "localhost" (parse-integer addr)
  • (open-network-stream "gnu-apl-connection" nil "localhost" (string-to-number addr) :type 'plain :return-list nil :end-of-command "\n"))

— Reply to this email directly or view it on GitHubhttps://github.com/lokedhs/gnu-apl-mode/issues/2 .