Changes in popup keyboard

lokedhs / gnu-apl-mode

GNU APL mode for Emacs

GNU General Public License v3.0

94 stars 18 forks source link

Changes in popup keyboard #27

Closed fourier closed 6 years ago

fourier commented 6 years ago

Implemented additonal tooltips mode: Added gnu-apl-keyboard-mouse-action-mode variable. If set to 'simplistic the keyboard help will show the symbol documentation in tooltip and insert symbol on mouse-1 event. The default behavior is kept as it is now.
Fixed bug when clicking on a keyboard the message "buffer is read only" was presented.
Now if user clicks on the keyboard to insert a symbol, the focus is moved back to interactive GNU APL session.
Non-special APL characters are now having tooltips and clickable in the popup keyboard, if documentation for them is available.

lokedhs commented 6 years ago

These are good changes. However, I did make some comments to the commit. Could you check those?

fourier commented 6 years ago

I cant see your comments, have you published them?

lokedhs commented 6 years ago

That's fine. If it actually works in both modes, then you can leave it as is. You probably know more about that behaviour than I at this point.

Also, do you feel that the simplified mode should be default?

fourier commented 6 years ago

I feel it is (but you need to test decide how do you like it, and maybe others?), since the user interaction via mouse is pretty simple and what you could expect from typical "on-screen" keyboards - left mouse button to insert a symbol and mouse over to provide a hint on symbol. To me it is pretty logical.

lokedhs commented 6 years ago

I have no problems with enabling it by default. Please go ahead and make the necessary changes and I'll be happy to merge.

fourier commented 6 years ago

Updated.